Skip to content

bpo-33995: fix ssl tests when built with LibreSSL #8050

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 3 commits into from

Conversation

alanhuang122
Copy link

@alanhuang122 alanhuang122 commented Jul 2, 2018

LibreSSL handles setting minimum and maximum protocol
versions for SSL contexts differently than OpenSSL.
This commit adds ssl.TLSVersion.{MAX,MIN}IMUM_AVAILABLE
constants, and fixes test_min_max_version under LibreSSL.

https://bugs.python.org/issue33995

Alan Huang added 2 commits July 2, 2018 09:56
LibreSSL handles setting minimum and maximum protocol
versions for SSL contexts differently than OpenSSL.
This commit adds ssl.TLSVersion.{MAX,MIN}IMUM_AVAILABLE
constants, and fixes test_min_max_version under LibreSSL.
@vstinner
Copy link
Member

An alternative PR has been merged: PR #11510. I close this one.

@vstinner vstinner closed this Jan 18, 2019
@alanhuang122
Copy link
Author

alanhuang122 commented Jan 26, 2019

bpo-33995 and bpo-35045 aren't duplicate issues. I don't have any issue with the PR being closed, though, since this is only a test failure and LibreSSL is unsupported, per Christian's comments.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants