gh-90829: Changing error message in builtins.min/max #91559
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
When passing an empty iterable to min function, such as min(set()), it returns the error 'arg is an empty sequence'. 'arg' does not match any argument of the function signature. Also, the iterable argument does not need to be a sequence. This commit changes it to 'iterable argument is an empty sequence'.
|
All commit authors signed the Contributor License Agreement. |
|
Changing it to iterable doesn't read well and makes the message less understandable. Perhaps change it to just say that input is empty (no need to specify a type) or that "at least one data value is required". Alternatively, just leave it as is — this is a really minor and inconsequential nitpick. |
|
Ok, I think we don't need to fix anything here. Thanks for the feedback! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
gh-90829: Fixed builtin.min/max error messages when iterable is empty
When passing an empty iterable to min function, such as
min(set()), it returns the error 'arg is an empty sequence'.
'arg' does not match any argument of the function signature.
Also, the iterable argument does not need to be a sequence.
This commit changes it to 'iterable argument is an empty sequence'.