-
-
Notifications
You must be signed in to change notification settings - Fork 32.2k
gh-92019: Make sqlite3.Blob indexing conform with the norm #92020
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
gh-92019: Make sqlite3.Blob indexing conform with the norm #92020
Conversation
- get index now returns an int - set index now requires an int in range(0, 256)
I'm not sure this needs a NEWS item; the blob interface has not been part of an official release yet. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thank you for the quick change! I'll take a closer look soon. I don't think it needs a NEWS entry because the current behavior wasn't released in any alpha.
Also, something wrong on Windows:
|
I'm on it 🕵🏻 UPDATE: fixed in 1badacb |
🤖 New build scheduled with the buildbot fleet by @JelleZijlstra for commit a713df6 🤖 If you want to schedule another build, you need to add the ":hammer: test-with-buildbots" label again. |
🤖 New build scheduled with the buildbot fleet by @erlend-aasland for commit 6400ec5 🤖 If you want to schedule another build, you need to add the ":hammer: test-with-buildbots" label again. |
🤖 New build scheduled with the buildbot fleet by @erlend-aasland for commit b0fc557 🤖 If you want to schedule another build, you need to add the ":hammer: test-with-buildbots" label again. |
One buildbot failed on |
I just merged python/cpython#92020 which implemented this change (thanks @erlend-aasland!).
I just merged python/cpython#92020 which implemented this change (thanks @erlend-aasland!).
Resolves #92019