gh-92536: Compute unicode struct sizes to ensure MemError is raised #92867
+6
−10
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sweeneyde
added
the
🔨 test-with-buildbots
|
🤖 New build scheduled with the buildbot fleet by @sweeneyde for commit 111ece3 🤖 If you want to schedule another build, you need to add the ":hammer: test-with-buildbots" label again. |
bedevere-bot
removed
the
🔨 test-with-buildbots
|
Gentoo bots are green for the first time in a little while. |
methane
approved these changes
May 17, 2022
|
Could this be backported to 3.11 and 3.10? |
|
Sure, it could, but it's not changing anything there other than clarity. The main reason it matters is that Unicode struct size changed in 3.12 due to PEP 623. |
|
OK, nevermind then. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I believe this is the cause of recent failing x86 Gentoo buildbots.