gh-92914: Round the allocated size for lists up to the even number #92915
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
serhiy-storchaka
added
performance
methane
reviewed
May 18, 2022
Objects/listobject.c
Outdated
| @@ -94,6 +94,16 @@ list_preallocate_exact(PyListObject *self, Py_ssize_t size) | |||
| assert(self->ob_item == NULL); | |||
| assert(size > 0); | |||
|
|
|||
| /* Since the Python memory allocator has granularity of 16 bytes, | |||
There was a problem hiding this comment.
alignment is 8bytes on 32bit platform.
Lines 878 to 884 in b86d783
So I think we don't need the else { block.
methane
approved these changes
May 18, 2022
serhiy-storchaka
changed the title
serhiy-storchaka
changed the title
AlexWaygood
added
needs backport to 3.11
|
Thanks @serhiy-storchaka for the PR 🌮🎉.. I'm working now to backport this PR to: 3.10, 3.11. |
|
GH-92941 is a backport of this pull request to the 3.11 branch. |
miss-islington
pushed a commit
to miss-islington/cpython
that referenced
this pull request
May 19, 2022
…ber (pythonGH-92915) (cherry picked from commit 8a6af5a) Co-authored-by: Serhiy Storchaka <[email protected]>
|
GH-92942 is a backport of this pull request to the 3.10 branch. |
miss-islington
pushed a commit
to miss-islington/cpython
that referenced
this pull request
May 19, 2022
…ber (pythonGH-92915) (cherry picked from commit 8a6af5a) Co-authored-by: Serhiy Storchaka <[email protected]>
ambv
pushed a commit
that referenced
this pull request
Jun 7, 2022
…H-92915) (GH-92942) (cherry picked from commit 8a6af5a) Co-authored-by: Serhiy Storchaka <[email protected]>
miss-islington
added a commit
that referenced
this pull request
Jun 14, 2022
…H-92915) (cherry picked from commit 8a6af5a) Co-authored-by: Serhiy Storchaka <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #92914.