[3.11] gh-93156 - fix negative indexing into absolute pathlib.PurePath().parents (GH-93273)
#93479
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…h().parents` (pythonGH-93273) When a `_PathParents` object has a drive or a root, the length of the object is *one less* than than the length of `self._parts`, which resulted in an off-by-one error when `path.parents[-n]` was fed through to `self._parts[:-n - 1]`. In particular, `path.parents[-1]` was a malformed path object with spooky properties. This is addressed by adding `len(self)` to negative indices. (cherry picked from commit f32e6b4) Co-authored-by: Barney Gale <[email protected]>
|
Status check is done, and it's a success ✅ . |
|
Status check is done, and it's a success ✅ . |
1 similar comment
|
Status check is done, and it's a success ✅ . |
bedevere-bot
added
type-bug
brettcannon
approved these changes
Jun 3, 2022
|
Status check is done, and it's a success ✅ . |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When a
_PathParentsobject has a drive or a root, the length of theobject is one less than than the length of
self._parts, which resultedin an off-by-one error when
path.parents[-n]was fed through toself._parts[:-n - 1]. In particular,path.parents[-1]was a malformedpath object with spooky properties.
This is addressed by adding
len(self)to negative indices.(cherry picked from commit f32e6b4)
Co-authored-by: Barney Gale [email protected]
Automerge-Triggered-By: GH:brettcannon