-
-
Notifications
You must be signed in to change notification settings - Fork 31.8k
gh-94584: Clarify tomllib
docs
#94585
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This seems unnecessary as there is no real change to the text other than using Deserialize
vs. Read
and Load
. Although technically correct I'm not even sure if it improves the readability that much.
This doesn't need a news entry.
@DanielNoord I made a few other changes, e.g.I combined a few short sentences into longer ones. I removed the NEWS entry in 3971067. |
In general such word smithing is not really necessary or desired. As you can see there is quite a backlog of open PRs so the time of maintainers is often best spent on meaningful changes to both code and documentation, rather than on sentences that essentially convey the same information. |
Okay. Should I close this? |
I think so, also based on the 👍 my other comment received. You can look for issues with the |
We do appreciate your efforts to contribute! If you find something that interests you in the list of issues, and if you’re not sure about some details, feel free to tag me (or ask on the core-mentorship mailing list if you prefer a more private channel). |
@merwok Is there any documentations or tips about attracting core reviewers to your PRs? I know reviews are in high demand and I don't want to spam tags/pings on my PRs so I wonder what the best way to generate some "buzz" for you PR is. |
Some topics have labels with people notified, others may be in the codeowners file, but I don’t know of any system or documentation other than https://devguide.python.org/pullrequest/#reviewing. You get lucky or you wait a bit then send a message on python discuss (the devguide mentions python-dev but discuss also has a core devel section). Here I am making a specific offer to help one new contributor! |
Closes gh-94584