gh-94438: in frameobject's mark_stacks, add explicit case for CACHE opcodes which leaves the stack unchanged #94586

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Closed

iritkatriel wants to merge 1 commit into python:main from iritkatriel:mark_stack_CACHE

Member

iritkatriel commented Jul 5, 2022 •

edited by bedevere-bot

Loading

This doesn't change behaviour, but it makes the code more explicit so it doesn't look like we forgot about CACHE opcodes.

The previous behaviour relied on stack_effect returning 0 for CACHE in the default case of the switch.

Issue: frame.setlineno has serious flaws. #94438


          pythongh-94438: in frameobject's mark_stacks, add explicit case for C…

0043d48

…ACHE opcodes which leaves the stack unchanged

iritkatriel added the skip news label

iritkatriel requested a review from markshannon as a code owner

July 5, 2022 22:36

bedevere-bot added the awaiting core review label

iritkatriel closed this

Member Author

iritkatriel commented Jul 5, 2022

This is wrong, as Dennis explained.

iritkatriel deleted the mark_stack_CACHE branch

September 29, 2022 17:03

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

awaiting core review skip news