Skip to content

gh-94844: Add pathlib support to shutil archive management #94846

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 12 commits into from
Jul 20, 2022
Merged

gh-94844: Add pathlib support to shutil archive management #94846

Changes from all commits
Commits
Show all changes
12 commits
Select commit Hold shift + click to select a range
3912f2e
Add pathlib support to shutil.make_archive
arhadthedev Jul 14, 2022
828abde
Add pathlib support to shutil._make_tarball
arhadthedev Jul 14, 2022
49a2158
Extend TestArchives with pathlib cases
arhadthedev Jul 14, 2022
deebebc
Address a Barney's review
arhadthedev Jul 14, 2022
0e14249
Fix accidental passing of `self` into a non-method
arhadthedev Jul 14, 2022
26d736c
Move os.fspath call into a higher level
arhadthedev Jul 14, 2022
85bf9f1
Revert the extra set of tests and the replacement with f-strings
arhadthedev Jul 14, 2022
f099b32
Restore a newline missing in Github raw view
arhadthedev Jul 14, 2022
debd99b
Merge branch 'main' into fix-shutil-makearchive
arhadthedev Jul 16, 2022
ff94966
Address the Serhiy's review
arhadthedev Jul 16, 2022
bdaf3f9
Address the Barney's review
arhadthedev Jul 16, 2022
5a1c347
Add a forgotten comment from the review
arhadthedev Jul 16, 2022
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 2 additions & 0 deletions Lib/shutil.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1118,6 +1118,8 @@ def make_archive(base_name, format, root_dir=None, base_dir=None, verbose=0,
save_cwd = None
if root_dir is not None:
if support_root_dir:
# Support path-like base_name here for backwards-compatibility.
base_name = os.fspath(base_name)
kwargs['root_dir'] = root_dir
else:
save_cwd = os.getcwd()
Expand Down