Skip to content

gh-94673: Add Per-Interpreter tp_weaklist for Static Builtin Types #95302

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 7 commits into from
Jul 29, 2022
Merged

gh-94673: Add Per-Interpreter tp_weaklist for Static Builtin Types #95302

merged 7 commits into from
Jul 29, 2022

Conversation

ericsnowcurrently
Copy link
Member

@ericsnowcurrently ericsnowcurrently commented Jul 26, 2022 •
edited by bedevere-bot
Loading

@ericsnowcurrently ericsnowcurrently removed the request for review from markshannon July 26, 2022 23:33
@ericsnowcurrently ericsnowcurrently mentioned this pull request Jul 26, 2022
Closed
@ericsnowcurrently ericsnowcurrently added the 🔨 test-with-buildbots Test PR w/ buildbots; report in status section label Jul 27, 2022
@ericsnowcurrently ericsnowcurrently mentioned this pull request Jul 27, 2022
Open
@ericsnowcurrently ericsnowcurrently merged commit 3e7cad3 into python:main Jul 29, 2022
@ericsnowcurrently ericsnowcurrently deleted the shareable-static-types-tp_weaklist branch July 29, 2022 01:23
@markshannon
Copy link
Member

@ericsnowcurrently
Have you benchmarked this?

I expect that it won't make any difference, but I'm a bit concerned as _PyObject_GET_WEAKREFS_LISTPTR is on the "fast" path of normal object de-allocation. I put "fast" in quotes because it is far from fast, but I don't want to make it any slower.

It seems to me, that the extra check is not needed during de-allocation.

@ericsnowcurrently
Copy link
Member Author

Good point. I'll take a look Monday.

@ericsnowcurrently
Copy link
Member Author

Pyperformance shows 1.01x slower, so I'll need to address that.

@ericsnowcurrently ericsnowcurrently mentioned this pull request Aug 1, 2022
Merged
ericsnowcurrently added a commit that referenced this pull request Aug 4, 2022
@ericsnowcurrently
gh-94673: Recover Weaklist Lookup Performance (gh-95544)
bdbadb9 
gh-95302 seems to have introduced a small performance regression. Here we make some minor changes to recover that lost performance.
iritkatriel pushed a commit to iritkatriel/cpython that referenced this pull request Aug 11, 2022
@ericsnowcurrently @iritkatriel
pythongh-94673: Recover Weaklist Lookup Performance (pythongh-95544)
225c3bc 
pythongh-95302 seems to have introduced a small performance regression. Here we make some minor changes to recover that lost performance.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@kumaraditya303 kumaraditya303 kumaraditya303 left review comments

Assignees
No one assigned
Labels
skip news
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@ericsnowcurrently @markshannon @kumaraditya303