Skip to content

gh-93267: Fix documentation for datetime module #95403

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Jul 29, 2022
Merged

gh-93267: Fix documentation for datetime module #95403

merged 1 commit into from
Jul 29, 2022

Conversation

BenjaminHelyer
Copy link
Contributor

@BenjaminHelyer BenjaminHelyer commented Jul 28, 2022 •
edited by bedevere-bot
Loading

Updating documentation for datetime module, as per issue #93267

@ghost
Copy link

ghost commented Jul 28, 2022 •
edited by ghost
Loading

All commit authors signed the Contributor License Agreement.
CLA signed

@bedevere-bot
Copy link

Most changes to Python require a NEWS entry.

Please add it using the blurb_it web app or the blurb command-line tool.

@bedevere-bot bedevere-bot added docs Documentation in the Doc dir skip news labels Jul 28, 2022
@BenjaminHelyer
Copy link
Contributor Author

Most changes to Python require a NEWS entry.

Please add it using the blurb_it web app or the blurb command-line tool.

I am assuming this doesn't need a NEWS entry since this is just a documentation update. If it's needed, I can make one.

@ericvsmith
Copy link
Member

I am assuming this doesn't need a NEWS entry since this is just a documentation update. If it's needed, I can make one.

It's not needed for this tiny change.

@ericvsmith ericvsmith added needs backport to 3.10 only security fixes needs backport to 3.11 only security fixes labels Jul 29, 2022
@ericvsmith ericvsmith self-assigned this Jul 29, 2022
@ericvsmith ericvsmith merged commit 6e44bf9 into python:main Jul 29, 2022
@miss-islington
Copy link
Contributor

Thanks @BenjaminHelyer for the PR, and @ericvsmith for merging it 🌮🎉.. I'm working now to backport this PR to: 3.10, 3.11.
🐍🍒⛏🤖

miss-islington pushed a commit to miss-islington/cpython that referenced this pull request Jul 29, 2022
@BenjaminHelyer @miss-islington
Improve documentation for adding datetime and timedelta (pythongh-95403)
69161dd 
(cherry picked from commit 6e44bf9)

Co-authored-by: BenjaminHelyer <[email protected]>
@bedevere-bot bedevere-bot removed the needs backport to 3.11 only security fixes label Jul 29, 2022
@bedevere-bot
Copy link

GH-95408 is a backport of this pull request to the 3.11 branch.

miss-islington pushed a commit to miss-islington/cpython that referenced this pull request Jul 29, 2022
@BenjaminHelyer @miss-islington
Improve documentation for adding datetime and timedelta (pythongh-95403)
baabe9a 
(cherry picked from commit 6e44bf9)

Co-authored-by: BenjaminHelyer <[email protected]>
@bedevere-bot
Copy link

GH-95409 is a backport of this pull request to the 3.10 branch.

@bedevere-bot bedevere-bot removed the needs backport to 3.10 only security fixes label Jul 29, 2022
@ericvsmith
Copy link
Member

Thanks, @BenjaminHelyer!

ericvsmith pushed a commit that referenced this pull request Jul 29, 2022
@miss-islington @BenjaminHelyer
Improve documentation for adding datetime and timedelta (gh-95403) (g…
3e9a496 
…h-95408)

(cherry picked from commit 6e44bf9)

Co-authored-by: BenjaminHelyer <[email protected]>

Co-authored-by: BenjaminHelyer <[email protected]>
ericvsmith pushed a commit that referenced this pull request Jul 29, 2022
@miss-islington @BenjaminHelyer
Improve documentation for adding datetime and timedelta (gh-95403) (g…
5632c98 
…h-95409)

(cherry picked from commit 6e44bf9)

Co-authored-by: BenjaminHelyer <[email protected]>

Co-authored-by: BenjaminHelyer <[email protected]>
@BenjaminHelyer BenjaminHelyer deleted the DateTimeDocFix branch July 29, 2022 02:45
@BenjaminHelyer
Copy link
Contributor Author

Thank you @ericvsmith for the email to Core-mentorship, and thank you all for the help! This was my first pull request ever on an open source project, and I am so excited to dive deeper. Now will leave future simple documentation changes for others who haven't been able to do this yet.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@merwok merwok merwok left review comments

@ericvsmith ericvsmith ericvsmith approved these changes

@pganssle pganssle Awaiting requested review from pganssle pganssle is a code owner

@abalkin abalkin Awaiting requested review from abalkin abalkin is a code owner

Assignees

@ericvsmith ericvsmith

Labels
docs Documentation in the Doc dir skip news
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@BenjaminHelyer @bedevere-bot @ericvsmith @miss-islington @merwok