Skip to content

GH-95909: Make _PyArg_Parser initialization thread safe #95958

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 6 commits into from
Aug 16, 2022
Merged

GH-95909: Make _PyArg_Parser initialization thread safe #95958

merged 6 commits into from
Aug 16, 2022

Conversation

kumaraditya303
Copy link
Contributor

@kumaraditya303 kumaraditya303 commented Aug 13, 2022 •
edited by miss-islington
Loading

Automerge-Triggered-By: GH:ericsnowcurrently

@kumaraditya303 kumaraditya303 mentioned this pull request Aug 13, 2022
Closed
@kumaraditya303 kumaraditya303 force-pushed the thread-safe-init-parser branch from 66d2443 to 242efec Compare August 15, 2022 08:38
ericsnowcurrently
ericsnowcurrently requested changes Aug 15, 2022
View reviewed changes
Copy link
Member

@ericsnowcurrently ericsnowcurrently left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yeah, this works and is definitely simpler than my PR. I only have one point to discuss (regarding the atomic get/set).

@bedevere-bot
Copy link

A Python core developer has requested some changes be made to your pull request before we can consider merging it. If you could please address their requests along with any other requests in other reviews from core developers that would be appreciated.

Once you have made the requested changes, please leave a comment on this pull request containing the phrase I have made the requested changes; please review again. I will then notify any core developers who have left a review that you're ready for them to take another look at this pull request.

@kumaraditya303 kumaraditya303 marked this pull request as ready for review August 16, 2022 14:50
ericsnowcurrently
ericsnowcurrently requested changes Aug 16, 2022
View reviewed changes
Copy link
Member

@ericsnowcurrently ericsnowcurrently left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Mostly LGTM. I have just a few minor comments.

@kumaraditya303
Copy link
Contributor Author

Mostly LGTM. I have just a few minor comments.

I had the changes but GitHub was crashing so hadn't pushed them, I have fixed them now.

@miss-islington miss-islington merged commit 9b30b96 into python:main Aug 16, 2022
@ericsnowcurrently
Copy link
Member

Thanks @kumaraditya303!

@kumaraditya303 kumaraditya303 deleted the thread-safe-init-parser branch August 17, 2022 15:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ericsnowcurrently ericsnowcurrently ericsnowcurrently approved these changes

Assignees
No one assigned
Labels
skip news
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@kumaraditya303 @bedevere-bot @ericsnowcurrently @miss-islington