gh-96197: Define the behavior of breakpoint if sys.breakpointhook is … #96231
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
bedevere-bot
added
docs
corona10
added
needs backport to 3.10
|
Thanks @corona10 for the PR 🌮🎉.. I'm working now to backport this PR to: 3.10, 3.11. |
|
GH-96240 is a backport of this pull request to the 3.11 branch. |
|
GH-96241 is a backport of this pull request to the 3.10 branch. |
miss-islington
pushed a commit
to miss-islington/cpython
that referenced
this pull request
Aug 24, 2022
…ok is lost (pythongh-96231) (cherry picked from commit 09563a7) Co-authored-by: Dong-hee Na <[email protected]>
miss-islington
pushed a commit
to miss-islington/cpython
that referenced
this pull request
Aug 24, 2022
…ok is lost (pythongh-96231) (cherry picked from commit 09563a7) Co-authored-by: Dong-hee Na <[email protected]>
miss-islington
added a commit
that referenced
this pull request
Aug 24, 2022
…lost (gh-96231) (cherry picked from commit 09563a7) Co-authored-by: Dong-hee Na <[email protected]>
miss-islington
added a commit
that referenced
this pull request
Aug 24, 2022
…lost (gh-96231) (cherry picked from commit 09563a7) Co-authored-by: Dong-hee Na <[email protected]>
mdboom
pushed a commit
to mdboom/cpython
that referenced
this pull request
Aug 24, 2022
youknowone
reviewed
Aug 25, 2022
| @@ -164,6 +164,8 @@ are always available. They are listed here in alphabetical order. | |||
| :func:`sys.breakpointhook` can be set to some other function and | |||
| :func:`breakpoint` will automatically call that, allowing you to drop into | |||
| the debugger of choice. | |||
| If :func:`sys.breakpointhook` is not available to be called, this function will | |||
There was a problem hiding this comment.
This descriptions sounds like it will raise error when callable(sys.breakpointhook) is not true.
But when sys.breakpointhook is set but not callable, it doesn't raise RuntimeError. (e.g. setting it to 1) RuntimeError is raised only when getattr(sys, 'breakpointhook') is False.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
…lost
del sys.breakpointhookis not tested in test_builtin #96197