Skip to content

[3.7] Fix the Windows CI config. #96490

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Sep 1, 2022

Conversation

gpshead
Copy link
Member

@gpshead gpshead commented Sep 1, 2022

This matches what 3.8 did in 899eb41.

This PR is based off of #96489 as that includes a change that fixes the check_source action for this branch so that build CI actually runs.

This includes checking in an initial Abigail ABI definition for 3.7.
This matches what 3.8 did in 899eb41.
@gpshead gpshead added tests Tests in the Lib/test dir OS-windows skip issue labels Sep 1, 2022
@gpshead gpshead marked this pull request as ready for review September 1, 2022 21:02
@gpshead gpshead requested a review from zooba September 1, 2022 21:04
@gpshead
Copy link
Member Author

gpshead commented Sep 1, 2022

@zooba if you want this to be done another way, please edit the windows lines in the PR branch. :) this just copied what 3.8 has today.

@gpshead gpshead requested a review from ned-deily September 1, 2022 21:05
@ned-deily ned-deily merged commit 9da3502 into python:3.7 Sep 1, 2022
@gpshead gpshead deleted the fix-windows-CI-config-37 branch September 1, 2022 23:28
@zooba
Copy link
Member

zooba commented Sep 2, 2022

Pinning the build machine image should be fine. We'll probably EOL 3.7 before those images disappear completely.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants