-
-
Notifications
You must be signed in to change notification settings - Fork 31.7k
gh-89536: Use ThinLTO policy if possible #96766
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
I will wait for @ned-deily 's review as the final reviewer since he is the expert on macOS releases. |
Should we do a performance benchmark of the generated executable? |
@matthiasgoergens |
Thanks! Ha, I should learn how this |
@ned-deily @methane cc @matthiasgoergens https://gist.github.com/corona10/40d48caebb498ade456d2332c4fa430e Here is the latest benchmark with my local macOS environment(not fully isolated) when applying only LTO optimization. |
Here is the PGO + LTO benchmark (consistently 3-4% faster :)) https://gist.github.com/corona10/60d73e610f14661e131ed9037eab4d38 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
Thank you @ronaldoussoren and @methane |
--with-lto
flag (AS-IS: LTO): 112.02 secs--with-lto
flag (TO-BE: ThinLTO): 56.150 secs (almost 2x faster)Both builds were done with M1 Pro CPU