Skip to content

gh-97654: Add auto exception chaining example to tutorial #97703

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Oct 5, 2022

Conversation

smheidrich
Copy link
Contributor

@smheidrich smheidrich commented Oct 1, 2022

This PR aims to make the tutorial's section on exception chaining clearer using the approach I suggested in #97654 (comment), i.e. by showing "automatic" exception chaining (without raise ... from) first and only then moving on to raise ... from to show how it's different and what its purpose is.

Fixes #97654.

@bedevere-bot bedevere-bot added awaiting review docs Documentation in the Doc dir skip news labels Oct 1, 2022
@ghost
Copy link

ghost commented Oct 1, 2022

All commit authors signed the Contributor License Agreement.
CLA signed

@JelleZijlstra JelleZijlstra added needs backport to 3.10 only security fixes needs backport to 3.11 only security fixes labels Oct 5, 2022
@JelleZijlstra JelleZijlstra merged commit 395b66a into python:main Oct 5, 2022
@miss-islington
Copy link
Contributor

Thanks @smheidrich for the PR, and @JelleZijlstra for merging it 🌮🎉.. I'm working now to backport this PR to: 3.10, 3.11.
🐍🍒⛏🤖

@JelleZijlstra JelleZijlstra added needs backport to 3.10 only security fixes needs backport to 3.11 only security fixes and removed needs backport to 3.10 only security fixes needs backport to 3.11 only security fixes labels Oct 5, 2022
@miss-islington
Copy link
Contributor

Thanks @smheidrich for the PR, and @JelleZijlstra for merging it 🌮🎉.. I'm working now to backport this PR to: 3.10.
🐍🍒⛏🤖

@miss-islington
Copy link
Contributor

Thanks @smheidrich for the PR, and @JelleZijlstra for merging it 🌮🎉.. I'm working now to backport this PR to: 3.11.
🐍🍒⛏🤖

@bedevere-bot bedevere-bot removed the needs backport to 3.10 only security fixes label Oct 5, 2022
@bedevere-bot
Copy link

GH-97884 is a backport of this pull request to the 3.10 branch.

miss-islington pushed a commit to miss-islington/cpython that referenced this pull request Oct 5, 2022
…onGH-97703)

Add auto exception chaining example to tutorial
(cherry picked from commit 395b66a)

Co-authored-by: Shahriar Heidrich <smheidrich@weltenfunktion.de>
@bedevere-bot bedevere-bot removed the needs backport to 3.11 only security fixes label Oct 5, 2022
@bedevere-bot
Copy link

GH-97885 is a backport of this pull request to the 3.11 branch.

miss-islington pushed a commit to miss-islington/cpython that referenced this pull request Oct 5, 2022
…onGH-97703)

Add auto exception chaining example to tutorial
(cherry picked from commit 395b66a)

Co-authored-by: Shahriar Heidrich <smheidrich@weltenfunktion.de>
ambv pushed a commit that referenced this pull request Oct 5, 2022
…97703) (#97885)

gh-97654: Add auto exception chaining example to tutorial (GH-97703)

Add auto exception chaining example to tutorial
(cherry picked from commit 395b66a)

Co-authored-by: Shahriar Heidrich <smheidrich@weltenfunktion.de>
ambv pushed a commit that referenced this pull request Oct 5, 2022
…97703) (#97884)

Add auto exception chaining example to tutorial
(cherry picked from commit 395b66a)

Co-authored-by: Shahriar Heidrich <smheidrich@weltenfunktion.de>
mpage pushed a commit to mpage/cpython that referenced this pull request Oct 11, 2022
pablogsal pushed a commit that referenced this pull request Oct 22, 2022
…97703) (#97885)

gh-97654: Add auto exception chaining example to tutorial (GH-97703)

Add auto exception chaining example to tutorial
(cherry picked from commit 395b66a)

Co-authored-by: Shahriar Heidrich <smheidrich@weltenfunktion.de>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
docs Documentation in the Doc dir skip news
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Tutorial's claim about default exception chaining misleading
4 participants