Skip to content

Fix remaining broken links. #1013

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Dec 25, 2022
Merged

Conversation

ezio-melotti
Copy link
Member

This PR fixes the remaining broken links and closes #681.

@ezio-melotti ezio-melotti requested a review from hugovk December 25, 2022 05:54
@ezio-melotti ezio-melotti self-assigned this Dec 25, 2022
:cpy-file:`Doc/library/token-list.inc`. If you change both ``python.gram``
and ``Tokens``, run ``make regen-token`` before ``make regen-pegen``.
changing it, run ``make regen-token`` to regenerate
:cpy-file:`Include/internal/pycore_token.h`, :cpy-file:`Parser/token.c`,
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Include/token.h was renamed to Include/internal/pycore_token.h (the rest is paragraph reflow).

Then run ``make regen-ast`` to regenerate :cpy-file:`Include/Python-ast.h`
and :cpy-file:`Python/Python-ast.c`.
Then run ``make regen-ast`` to regenerate
:cpy-file:`Include/internal/pycore_ast.h` and :cpy-file:`Python/Python-ast.c`.
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Include/Python-ast.h was moved to Include/internal/pycore_ast.h.

@@ -490,7 +490,7 @@ Finally, you need to introduce the use of the new bytecode. Altering
places to change. You must add the case for a new opcode into the 'switch'
statement in the ``stack_effect()`` function in :cpy-file:`Python/compile.c`.
If the new opcode has a jump target, you will need to update macros and
'switch' statements in :cpy-file:`Python/peephole.c`. If it affects a control
'switch' statements in :cpy-file:`Python/compile.c`. If it affects a control
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The relevant code was apparently moved into Python/compile.c in python/cpython#21517.

Comment on lines -582 to -586
* :cpy-file:`Python/peephole.c`: Optimizes the bytecode.

* :cpy-file:`Python/pyarena.c`: Implementation of the arena memory manager.

* :cpy-file:`Python/wordcode_helpers.h`: Helpers for generating bytecode.
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Both got merged into Python/compile.c, which is already listed above, so I removed these.

Copy link
Member

@CAM-Gerlach CAM-Gerlach left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

One not-directly-related comment, but LGTM at least from a basic source diff inspection and spot-checking the rendered preview

Copy link
Member

@hugovk hugovk left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks! 🎄

@hugovk hugovk merged commit c0e1638 into python:main Dec 25, 2022
@ezio-melotti ezio-melotti deleted the fix-broken-links branch December 25, 2022 23:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Fix broken links in the Devguide
3 participants