Fix dead links to the tokenizer's source code#1250
Merged
AlexWaygood merged 3 commits intopython:mainfrom Dec 19, 2023
MahadMuhammad:fixes/token.c-link
Merged
Fix dead links to the tokenizer's source code#1250AlexWaygood merged 3 commits intopython:mainfrom MahadMuhammad:fixes/token.c-link
AlexWaygood merged 3 commits intopython:mainfrom
MahadMuhammad:fixes/token.c-link
Conversation
|
All commit authors signed the Contributor License Agreement. |
AlexWaygood
previously requested changes
Dec 17, 2023
Member
There was a problem hiding this comment.
Thanks for the PR! It's not quite correct currently, however. The tokenizer was refactored into two new directories, Parser/lexer/ and Parser/tokenizer/, in python/cpython#110684. The link here should point to one or both of those directories rather than token.c.
Member
|
@lysnikolaou, does this look okay to you? Should we be linking to both directories in these places, or just one of the two? |
ezio-melotti
approved these changes
Dec 17, 2023
lysnikolaou
reviewed
Dec 18, 2023
Member
lysnikolaou
left a comment
lysnikolaou
left a comment
There was a problem hiding this comment.
I would just change this one occurrence to point to the lexer, which contains the pure tokenization code. The following sentence makes more sense this way.
Thanks for the ping @AlexWaygood!
AlexWaygood
changed the title
token.c hyperlink in compiler design
AlexWaygood
changed the title
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixed
token.chyperlink in compiler designtoken.cfile, which can be seen herecpython-devguide--1245.org.readthedocs.build/📚 Documentation preview 📚: https://cpython-devguide--1250.org.readthedocs.build/