-
-
Notifications
You must be signed in to change notification settings - Fork 848
Update backport instructions #178
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
Remove the part about merging into master. Remove the part about prefixing the PR title with `X.Y`, cherry_picker.py already does this. Closes #173
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks great @Mariatta. One small question.
committing.rst
Outdated
@@ -408,45 +408,25 @@ new features. The other branches only receive bug fixes or security fixes. | |||
|
|||
.. _branch-merge: | |||
|
|||
Backporting changes to Python 3.6 (or older version) | |||
---------------------------------------------------- | |||
Backporting Changes to Older Version |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@Mariatta: Should there be an an
before Older Version
?
Thanks :) Updated. |
I think the part about prefixing PR title should stay for now. Not every core dev use cherry_picker.py yet :) |
A reasonable comment during the transition @berkerpeksag. Perhaps adding a small note about prefixing the PR title and marking it "legacy process" and the cherry_picker.py as the "preferred process". @Mariatta thoughts? |
Sounds reasonable :) I'm reviewing the other PR now, and will add back the PR prefix after. |
* Update backport instructions Remove the part about merging into master. Remove the part about prefixing the PR title with `X.Y`, cherry_picker.py already does this. Closes python#173 * hash -> hashes * add `an`
Remove the part about merging into master.
Remove the part about prefixing the PR title with
X.Y
, cherry_picker.py already does this.Closes #173