-
-
Notifications
You must be signed in to change notification settings - Fork 847
Fix broken links #683
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix broken links #683
Conversation
Hello, and thanks for your contribution! I'm a bot set up to make sure that the project can legally accept this contribution by verifying everyone involved has signed the PSF contributor agreement (CLA). Recognized GitHub usernameWe couldn't find a bugs.python.org (b.p.o) account corresponding to the following GitHub usernames: This might be simply due to a missing "GitHub Name" entry in one's b.p.o account settings. This is necessary for legal reasons before we can look at this contribution. Please follow the steps outlined in the CPython devguide to rectify this issue. You can check yourself to see if the CLA has been received. Thanks again for the contribution, we look forward to reviewing it! |
.. _tx_pl: https://www.transifex.com/python-doc/python-newest/language/pl/ | ||
.. _tx_zh_cn: https://www.transifex.com/python-doc/python-newest/language/ | ||
.. _tx_pl: https://www.transifex.com/python-doc/python-newest/ | ||
.. _tx_zh_cn: https://www.transifex.com/python-doc/python-newest/ |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Does this look correct, @JulienPalard? Are there better urls for these?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This is complicated. Transifex give 404 when someone is not logged (I don't like it).
So https://www.transifex.com/python-doc/python-newest/language/pl/ and https://www.transifex.com/python-doc/python-newest/language/zh_CN/ are the real URLs, which only work for logged in users. Maybe https://www.transifex.com/python-doc/python-newest/ is more friendly, as I don't expect much people to already be logged in on transifex when clicking the link.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks great overall, thanks. Just wasn't sure about the transifex urls.
@Mariatta , mam i am a big fan of yours!😬. i read the GitHub readme project and there your profile was featured showing that people contributing for mars copter will get a badge, i stalked your GitHub and realized, you have done great work!. |
Thanks for the kind message and for your contribution! |
#681