Skip to content

Fix broken links #683

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged

Conversation

himanshu007-creator
Copy link
Contributor

@the-knights-who-say-ni
Copy link

Hello, and thanks for your contribution!

I'm a bot set up to make sure that the project can legally accept this contribution by verifying everyone involved has signed the PSF contributor agreement (CLA).

Recognized GitHub username

We couldn't find a bugs.python.org (b.p.o) account corresponding to the following GitHub usernames:

@himanshu007-creator

This might be simply due to a missing "GitHub Name" entry in one's b.p.o account settings. This is necessary for legal reasons before we can look at this contribution. Please follow the steps outlined in the CPython devguide to rectify this issue.

You can check yourself to see if the CLA has been received.

Thanks again for the contribution, we look forward to reviewing it!

.. _tx_pl: https://www.transifex.com/python-doc/python-newest/language/pl/
.. _tx_zh_cn: https://www.transifex.com/python-doc/python-newest/language/
.. _tx_pl: https://www.transifex.com/python-doc/python-newest/
.. _tx_zh_cn: https://www.transifex.com/python-doc/python-newest/
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Does this look correct, @JulienPalard? Are there better urls for these?

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is complicated. Transifex give 404 when someone is not logged (I don't like it).

So https://www.transifex.com/python-doc/python-newest/language/pl/ and https://www.transifex.com/python-doc/python-newest/language/zh_CN/ are the real URLs, which only work for logged in users. Maybe https://www.transifex.com/python-doc/python-newest/ is more friendly, as I don't expect much people to already be logged in on transifex when clicking the link.

Copy link
Member

@Mariatta Mariatta left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks great overall, thanks. Just wasn't sure about the transifex urls.

@himanshu007-creator
Copy link
Contributor Author

@Mariatta , mam i am a big fan of yours!😬. i read the GitHub readme project and there your profile was featured showing that people contributing for mars copter will get a badge, i stalked your GitHub and realized, you have done great work!.
Really felt awesome to work with you, 🌸

@Mariatta Mariatta merged commit 5048d2e into python:master May 2, 2021
@Mariatta
Copy link
Member

Mariatta commented May 2, 2021

Thanks for the kind message and for your contribution!

AA-Turner pushed a commit to AA-Turner/devguide that referenced this pull request Jun 17, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants