-
-
Notifications
You must be signed in to change notification settings - Fork 63
Fix japanese doc build error #144
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Use kotex package as the error claims that tex failed to process Korean character.
JulienPalard
approved these changes
Jan 17, 2023
Let's try this, thanks for working on it. |
Hi @JulienPalard, Did it work? If not, I think it's better to revert the change. |
Damned, it did not worked, I see this in the logs:
|
JulienPalard
added a commit
that referenced
this pull request
Jan 19, 2023
This reverts commit ec33098.
JulienPalard
added a commit
that referenced
this pull request
Jan 19, 2023
OK. @JulienPalard, thank you for the reverting the change. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changes aims to fix the problem on building Japanese PDF doc reported the following issue.
python/python-docs-ja#35
I've confirmed the the error disappeared in the build of Python 3.11 documentation on Docker container based on Ubuntu 22.04.
Please note that this fix is a workaround to avoid confronting error rather than the one to fix essential problem. Given that the
U+C4CF
is Korean character, I added an option to use Korean latex package. It is weird that Korean latex package is required to build Japanese documentation. But it appears that it somehow works.Any suggestions are welcome. Thanks in advance!