Skip to content

Don't run PEP561 tests in runtests.py by default #12879

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
JukkaL opened this issue May 27, 2022 · 1 comment · Fixed by #12883
Closed

Don't run PEP561 tests in runtests.py by default #12879

JukkaL opened this issue May 27, 2022 · 1 comment · Fixed by #12883
Labels
topic-developer Issues relevant to mypy developers topic-tests

Comments

@JukkaL
Copy link
Collaborator

JukkaL commented May 27, 2022

Now that PEP561 tests run sequentially (#12857), they can take a big fraction of the
entire runtests.py runtime. I think that we should make the tests opt-in, similar to some
of the slow mypyc tests. They will run in CI always in any case.

Anybody want to help with this?

@JukkaL JukkaL added the topic-developer Issues relevant to mypy developers label May 27, 2022
erikkemperman added a commit to erikkemperman/mypy that referenced this issue May 27, 2022
@erikkemperman
Copy link
Contributor

erikkemperman commented May 27, 2022

Anybody want to help with this?

Since I am responsible for making the PEP561 tests so much slower, I think it's only fair that I be the one to make them optional :-)

By the way, these tests aren't completely sequential, just the pip install steps were made to not overlap. It's a lot slower than before, to be sure, but pytest -n0 is even worse (at least on my machine).

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
topic-developer Issues relevant to mypy developers topic-tests
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants