Skip to content

(🎁) Deprecate python 3.7 support #15056

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
KotlinIsland opened this issue Apr 15, 2023 · 7 comments · Fixed by #15566
Closed

(🎁) Deprecate python 3.7 support #15056

KotlinIsland opened this issue Apr 15, 2023 · 7 comments · Fixed by #15566
Labels
priority-2-low refactoring Changing mypy's internals

Comments

@KotlinIsland
Copy link
Contributor

Python 3.7 is an old reference (deprecated), maybe mypy should drop support for it 😳

PEP 537 -- Python 3.7 Release Schedule

It's actually deprecated as of 2023-06, but close enough.

@ichard26 ichard26 added refactoring Changing mypy's internals priority-2-low labels Apr 19, 2023
@JelleZijlstra
Copy link
Member

3.7 has now reached EOL. Time to remove support?

@AlexWaygood
Copy link
Member

As @ikonst has noted elsewhere, the tests on 3.7 are by far the slowest in CI, so it would definitely be a nice quality of life improvement to be able to ditch them :)

@JelleZijlstra
Copy link
Member

Isn't some of that because we run a subset of tests on 3.7 only as it's the earliest supported version? Not sure that would be any better if we run them on 3.8 instead.

@AlexWaygood
Copy link
Member

Isn't some of that because we run a subset of tests on 3.7 only as it's the earliest supported version?

I wasn't aware that we did that!

@JelleZijlstra
Copy link
Member

If we don't drop support for 3.7 in the next release, we need to bump our typing-extensions requirements: #15543 (comment)

@ikonst
Copy link
Contributor

ikonst commented Jun 29, 2023

I think the issue I filed (#15303) was about windows running tests nearly 2x slower. Don't think 3.7 had to do with it.

@hauntsaninja
Copy link
Collaborator

hauntsaninja commented Jul 1, 2023

Let's pull the trigger and remove support for running under 3.7 (not checking). 3.7 is getting annoying. It's fallen to fewer than 10% of mypy users and I bet the fraction is even smaller for latest mypy version.

hauntsaninja added a commit to hauntsaninja/mypy that referenced this issue Jul 1, 2023
hauntsaninja added a commit to hauntsaninja/mypy that referenced this issue Jul 1, 2023
hauntsaninja added a commit to hauntsaninja/mypy that referenced this issue Jul 1, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
priority-2-low refactoring Changing mypy's internals
Projects
None yet
Development

Successfully merging a pull request may close this issue.

6 participants