Skip to content

--warn-unused-ignores also warns about typeshed #1884

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
Herst opened this issue Jul 16, 2016 · 2 comments
Closed

--warn-unused-ignores also warns about typeshed #1884

Herst opened this issue Jul 16, 2016 · 2 comments
Assignees
@ddfisher

Comments

@Herst
Copy link
Contributor

Herst commented Jul 16, 2016

Note sure whether that's expected or a workaround like for #1554 is needed:
/usr/lib/mypy/typeshed/stdlib/2and3/logging/handlers.pyi:107: note: unused 'type: ignore' comment
@Herst Herst changed the title --warn-unused-ignores also warns about typeshed imports --warn-unused-ignores also warns about typeshed Jul 16, 2016
@gvanrossum
Copy link
Member

That one is actually needed because of #698, and the ignore is not unused when --strict-optional is given. So I think we should just live with it until #698 is fixed and then we can remove it.

@gvanrossum gvanrossum added this to the 0.4.x milestone Jul 21, 2016
@ddfisher ddfisher self-assigned this Jul 21, 2016
@ddfisher
Copy link
Collaborator

It's also worth putting in the same workaround as in #1554 for now.

This was referenced Jul 21, 2016
Closed
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@ddfisher ddfisher

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
3 participants
@ddfisher @Herst @gvanrossum