Don't report unused type ignores in typeshed #1920
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| False, False) | ||
| self.error_info.append(info) | ||
|
|
||
| def is_typeshed_file(self, file): |
There was a problem hiding this comment.
This function needs annotations.
If you make this the accepted, public interface to determine whether a file is in the typeshed or not, you can refactor the code in checker.py that sets is_typeshed_stub there like this:
self.is_typeshed_stub = self.errors.is_typeshed_file(path)There was a problem hiding this comment.
That's a nice improvement. Fixed!
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #1884.
Feels a bit hacky, though. Not entirely sure how I feel about it.