Skip to content

Move the typing module to a separate installation package #377

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
JukkaL opened this issue Aug 14, 2014 · 10 comments
Closed

Move the typing module to a separate installation package #377

JukkaL opened this issue Aug 14, 2014 · 10 comments

Comments

@JukkaL
Copy link
Collaborator

JukkaL commented Aug 14, 2014

The typing module could be more generally useful even outside mypy, such as for annotating code for documentation purposes. Also, other tools such as IDEs, documentation tools could more easily use it.

This discussion on python-ideas is relevant:

https://mail.python.org/pipermail/python-ideas/2014-August/028618.html

EDIT: Changed from 'separate project' to a 'separate installation package'

@gvanrossum
Copy link
Member

It should be separately installable. But it should still live in the same
repo.

@JukkaL JukkaL changed the title Move the typing module to a separate project Move the typing module to a separate installation package Aug 14, 2014
@mvcisback
Copy link
Contributor

How do you feel about typing as a install dependency in setup.py and use requirements.txt to point to the typing package in the repo?

@iljabauer
Copy link

I like the idea of a separate repo. Maybe we could include it as dependency and as git-submodule?

On Fri, Aug 15, 2014 at 7:13 PM, Guido van Rossum
[email protected] wrote:

I am beginning to change my mind. Maybe typing.py should become a separate package in a separate repo after all, so that we can start working on the definitive version of typing.py to be included in the Python stdlib. (Of course, changes to typing.py would still need to be accompanied by changes in mypy, in most cases. But it might encourage contributors, and it could have its own, less overwhelming tracker.)

Reply to this email directly or view it on GitHub:
#377 (comment)

@gvanrossum
Copy link
Member

[I wrote this and accidentally deleted it]

I am beginning to change my mind. Maybe typing.py should become a separate package in a separate repo after all, so that we can start working on the definitive version of typing.py to be included in the Python stdlib. (Of course, changes to typing.py would still need to be accompanied by changes in mypy, in most cases. But it might encourage contributors, and it could have its own, less overwhelming tracker.)

@mvcisback
Copy link
Contributor

+1 for making it a separate repo

@JukkaL
Copy link
Collaborator Author

JukkaL commented Aug 16, 2014

Some additional points that support having a separate repo:

  1. It's more convenient to maintain documentation in a standard format, and written using a
    "neutral point of view" (i.e., not from the point of view of the mypy type checker).
  2. We can iterate on it more quickly since mypy can trail a bit behind. If it's part of mypy, every
    change in typing needs to be reflected in the mypy type parser, stubs files, documentation,
    potentially the type checker, etc.

@JukkaL
Copy link
Collaborator Author

JukkaL commented Aug 31, 2014

I created a new repo: https://github.com/JukkaL/typing

What do you think?

@mvcisback
Copy link
Contributor

nice, I think this is the right direction. It should make packaging a lot easier

@zyga
Copy link

zyga commented Sep 1, 2014

Thanks for doing that. I'll start packaging typing for Debian today.

2014-09-01 7:55 GMT+02:00 Marcell Vazquez-Chanlatte <
[email protected]>:

nice, I think this is the right direction. It should make packaging a lot
easier


Reply to this email directly or view it on GitHub
#377 (comment).

@JelleZijlstra
Copy link
Member

This is long obsolete, since typing is now in the stdlib and being developed in github.com/python/typing.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

6 participants