Skip to content

Generic propagation into dataclasses doesn't seem to work consistently #9585

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
bdowning opened this issue Oct 12, 2020 · 0 comments · Fixed by #18943
Closed

Generic propagation into dataclasses doesn't seem to work consistently #9585

bdowning opened this issue Oct 12, 2020 · 0 comments · Fixed by #18943
Labels
bug mypy got something wrong topic-dataclasses

Comments

@bdowning
Copy link

Bug Report

mypy doesn't seem to propagate generics into dataclass-generated methods correctly.

To Reproduce

from dataclasses import dataclass
from typing import TypeVar, Generic, Dict, Any

T = TypeVar("T")


class FloatValue:
    pass


@dataclass
class ValueByKey(Generic[T]):
    values: Dict[Any, T]


def foo(v: ValueByKey[FloatValue]):
    reveal_type(v.values)
    reveal_type(ValueByKey[FloatValue].__init__)

Expected Behavior

:; pipenv run mypy /tmp/footest.py
/tmp/footest.py:17: note: Revealed type is 'builtins.dict[Any, footest.FloatValue*]'
/tmp/footest.py:18: note: Revealed type is 'def (self: footest.ValueByKey[footest.FloatValue*], values: builtins.dict[Any, footest.FloatValue*])'

Actual Behavior

:; pipenv run mypy --version      
mypy 0.790
:; pipenv run mypy /tmp/footest.py
/tmp/footest.py:17: note: Revealed type is 'builtins.dict[Any, footest.FloatValue*]'
/tmp/footest.py:18: note: Revealed type is 'def (self: footest.ValueByKey[T`1], values: builtins.dict[Any, T`1])'

Your Environment

  • Mypy version used: 0.790
  • Mypy command-line flags: see above
  • Mypy configuration options from mypy.ini (and other config files): none
  • Python version used: 3.7.8
  • Operating system and version: Arch Linux
@bdowning bdowning added the bug mypy got something wrong label Oct 12, 2020
cdce8p pushed a commit to cdce8p/mypy that referenced this issue May 31, 2025
Fixes python#18024
Fixes python#18706
Fixes python#17734
Fixes python#15097
Fixes python#14814
Fixes python#14806
Fixes python#14259
Fixes python#13041
Fixes python#11993
Fixes python#9585
Fixes python#9266
Fixes python#9202
Fixes python#5481

This is a fourth "major" PR toward
python#7724. This is one is
watershed/crux of the whole series (but to set correct expectations,
there are almost a dozen smaller follow-up/clean-up PRs in the
pipeline).

The core of the idea is to set current type-checker as part of the
global state. There are however some details:
* There are cases where we call `is_subtype()` before type-checking. For
now, I fall back to old logic in this cases. In follow up PRs we may
switch to using type-checker instances before type checking phase (this
requires some care).
* This increases typeops import cycle by a few modules, but
unfortunately this is inevitable.
* This PR increases potential for infinite recursion in protocols. To
mitigate I add: one legitimate fix for `__call__`, and one temporary
hack for `freshen_all_functions_type_vars` (to reduce performance
impact).
* Finally I change semantics for method access on class objects to match
the one in old `find_member()`. Now we will expand type by instance, so
we have something like this:
  ```python
  class B(Generic[T]):
      def foo(self, x: T) -> T: ...
  class C(B[str]): ...
  reveal_type(C.foo)  # def (self: B[str], x: str) -> str
  ```
FWIW, I am not even 100% sure this is correct, it seems to me we _may_
keep the method generic. But in any case what we do currently is
definitely wrong (we infer a _non-generic_ `def (x: T) -> T`).

---------

Co-authored-by: hauntsaninja <[email protected]>
Co-authored-by: Shantanu <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug mypy got something wrong topic-dataclasses
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants