Remove types-typing-extensions dependency #10347
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This is due to python/typeshed#5233
|
Diff from mypy_primer, showing the effect of this PR on open source code: porcupine (https://github.com/Akuli/porcupine.git)
+ porcupine/settings.py:388: error: Unsupported operand types for < ("str" and "int") [operator]
|
JelleZijlstra
approved these changes
Apr 21, 2021
There was a problem hiding this comment.
Looks good, but curious what's going on with the mypy-primer change. It's on https://github.com/Akuli/porcupine/blob/master/porcupine/settings.py#L388, cc @Akuli.
|
It's because porcupine uses a custom typeshed dir, which has been updated for modular typeshed but hasn't been updated to include typing_extensions in the stdlib. I assume this prevents mypy from matching the Literal overloads. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is due to python/typeshed#5233