Now lambda is counted as a valid context in handle_cannot_determine_type
#11215
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This comment has been minimized.
This comment has been minimized.
|
Diff from mypy_primer, showing the effect of this PR on open source code: graphql-core (https://github.com/graphql-python/graphql-core.git)
+ tests/execution/test_union_interface.py:69: error: unused "type: ignore" comment
+ tests/execution/test_union_interface.py:75: error: unused "type: ignore" comment
+ tests/execution/test_union_interface.py:76: error: unused "type: ignore" comment
+ tests/execution/test_union_interface.py:77: error: unused "type: ignore" comment
+ tests/execution/test_union_interface.py:87: error: unused "type: ignore" comment
+ tests/execution/test_union_interface.py:88: error: unused "type: ignore" comment
+ tests/execution/test_union_interface.py:89: error: unused "type: ignore" comment
+ tests/execution/test_union_interface.py:100: error: unused "type: ignore" comment
+ tests/execution/test_union_interface.py:101: error: unused "type: ignore" comment
+ tests/execution/test_union_interface.py:102: error: unused "type: ignore" comment
+ tests/execution/test_union_interface.py:127: error: unused "type: ignore" comment
+ tests/execution/test_union_interface.py:128: error: unused "type: ignore" comment
+ tests/execution/test_union_interface.py:129: error: unused "type: ignore" comment
|
|
From LifeType = GraphQLInterfaceType(
"Life", lambda: {"progeny": GraphQLField(GraphQLList(LifeType))} # type: ignore
)Seems like a good thing to me. |
JukkaL
added a commit
that referenced
this pull request
Dec 9, 2021
…determine_type` (#11215)" (#11694) This reverts commit d37c2be. Lambdas can't be safely deferred. There are various subtle assumptions about lambdas not being deferred in different parts of the codebase, and figuring out how to do this safely is almost certainly not worth the trouble. This would be very difficult to validate, since lambda deferral would probably happen very rarely in practice.
tushar-deepsource
pushed a commit
to DeepSourceCorp/mypy
that referenced
this pull request
Jan 20, 2022
…determine_type` (python#11215)" (python#11694) This reverts commit d37c2be. Lambdas can't be safely deferred. There are various subtle assumptions about lambdas not being deferred in different parts of the codebase, and figuring out how to do this safely is almost certainly not worth the trouble. This would be very difficult to validate, since lambda deferral would probably happen very rarely in practice.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #11212
Previously
mypywas ignoringlambdascope inhandle_cannot_determine_type.I guess it was done to fix some
lambdarelated crashes.I've also noticed one crash with this new solution in existing test. I happened because when right
orpart is unreachable, there's notbinder.framefor it. So, I've made a temporary scope of it.