Improve ParamSpec type inference from lambda #11602
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
If ParamSpec is in the context of a lambda, treat it similar to `Callable[..., Any]`. This allows us to infer at least argument counts and kinds. Types can't be inferred since that would require "backwards" type inference, which we don't support. Follow-up to #11594.
ilevkivskyi
approved these changes
Nov 23, 2021
|
Diff from mypy_primer, showing the effect of this PR on open source code: spark (https://github.com/apache/spark.git)
- python/pyspark/shell.py:49: error: Cannot infer type of lambda [misc]
tornado (https://github.com/tornadoweb/tornado.git)
- tornado/util.py:55: error: Cannot infer type of lambda
|
tushar-deepsource
pushed a commit
to DeepSourceCorp/mypy
that referenced
this pull request
Jan 20, 2022
If ParamSpec is in the context of a lambda, treat it similar to `Callable[..., Any]`. This allows us to infer at least argument counts and kinds. Types can't be inferred since that would require "backwards" type inference, which we don't support. Follow-up to python#11594.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
If ParamSpec is in the context of a lambda, treat it similar
to
Callable[..., Any]. This allows us to infer at least argumentcounts and kinds. Types can't be inferred since that would require
"backwards" type inference, which we don't support.
Follow-up to #11594.