Fix daemon crashes related to ParamSpec and TypeVarTuple#13381
Merged
Conversation
Fix daemon crash when using fine-grained caching and ParamSpec, with traceback like this (when using a compiled mypy): ``` Traceback (most recent call last): File "mypy/dmypy_server.py", line 230, in serve File "mypy/dmypy_server.py", line 273, in run_command File "mypy/dmypy_server.py", line 372, in cmd_recheck File "mypy/dmypy_server.py", line 529, in fine_grained_increment File "mypy/server/update.py", line 245, in update File "mypy/server/update.py", line 328, in update_one File "mypy/server/update.py", line 387, in update_module File "mypy/server/astdiff.py", line 158, in snapshot_symbol_table File "mypy/server/astdiff.py", line 236, in snapshot_type File "mypy/types.py", line 1173, in accept File "mypy/server/astdiff.py", line 300, in visit_instance File "mypy/nodes.py", line 2764, in fullname AttributeError: attribute 'TypeInfo' of '_fullname' undefined ``` Also fix TypeVarTuple crashes when using daemon.
This comment has been minimized.
This comment has been minimized.
ilevkivskyi
approved these changes
Aug 23, 2022
This comment has been minimized.
This comment has been minimized.
1 similar comment
Contributor
|
According to mypy_primer, this change has no effect on the checked open source code. 🤖🎉 |
jhance
pushed a commit
that referenced
this pull request
Sep 9, 2022
* Fix daemon crashes related to ParamSpec and TypeVarTuple Fix daemon crash when using fine-grained caching and ParamSpec, with traceback like this (when using a compiled mypy): ``` Traceback (most recent call last): File "mypy/dmypy_server.py", line 230, in serve File "mypy/dmypy_server.py", line 273, in run_command File "mypy/dmypy_server.py", line 372, in cmd_recheck File "mypy/dmypy_server.py", line 529, in fine_grained_increment File "mypy/server/update.py", line 245, in update File "mypy/server/update.py", line 328, in update_one File "mypy/server/update.py", line 387, in update_module File "mypy/server/astdiff.py", line 158, in snapshot_symbol_table File "mypy/server/astdiff.py", line 236, in snapshot_type File "mypy/types.py", line 1173, in accept File "mypy/server/astdiff.py", line 300, in visit_instance File "mypy/nodes.py", line 2764, in fullname AttributeError: attribute 'TypeInfo' of '_fullname' undefined ``` Also fix TypeVarTuple crashes when using daemon. Co-authored-by: Ivan Levkivskyi <levkivskyi@gmail.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fix daemon crash when using fine-grained caching and ParamSpec, with
traceback like this (when using a compiled mypy):
Also fix TypeVarTuple crashes when using daemon.