-
-
Notifications
You must be signed in to change notification settings - Fork 2.9k
Support package and module in config file #13404
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
Specifying module(s) to check was supported only via CLI, this PR adds the ability to specify a module from a config file. Fixes #9883
This comment has been minimized.
This comment has been minimized.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks, this looks reasonable. Can we make packages
and modules
plural everywhere for consistency with files
and the option names?
`modules` and `packages` should be plural for consistency
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
@hauntsaninja looks like all checks are passing, is anything else needed? |
package and modules are *not* interchangeable
`modules` and `packages` are *not* identical
This comment has been minimized.
This comment has been minimized.
Co-authored-by: Jelle Zijlstra <[email protected]>
This comment has been minimized.
This comment has been minimized.
According to mypy_primer, this change has no effect on the checked open source code. 🤖🎉 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for working on this!
Description
Closes #10728
Specifying module(s) to check was supported only via CLI, this PR adds
the ability to specify a module from a config file.
Test Plan
This is a pretty small change, I tested it by creating a
mypy.ini
file and verifying that adding the new options leads to expected outcomes (for example, specifying apackage
andfiles
together will error heremypy/mypy/main.py
Lines 957 to 960 in ea93326
Do I need to rebuild the documentation after changing
config_file.rst
? If so, how is that done?Thanks!