Allow overloading to succeed if an arg is an instance of a class derived from Any. Fix #1363. #1365
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
gvanrossum
force-pushed
the
dictoverload
branch
from
3898246 to
853df6a
Compare
…ved from Any. Fix #1363
gvanrossum
force-pushed
the
dictoverload
branch
from
853df6a to
36cbc12
Compare
gvanrossum
changed the title
gvanrossum
changed the title
|
@JukkaL please review. This is the cleaned-up version of what we discussed today. |
| @@ -1625,7 +1625,8 @@ def overload_arg_similarity(actual: Type, formal: Type) -> int: | |||
| """ | |||
| if (isinstance(actual, NoneTyp) or isinstance(actual, AnyType) or | |||
| isinstance(formal, AnyType) or isinstance(formal, TypeVarType) or | |||
| isinstance(formal, CallableType)): | |||
| isinstance(formal, CallableType) or | |||
| isinstance(actual, Instance) and actual.type.fallback_to_any): | |||
There was a problem hiding this comment.
Add parentheses around the and expression for clarity.
|
Looks good, other than the nits above. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This has some tests that simulate the reported problem, and the hack makes them pass; but the reported case still fails outside the test harness (probably because fixtures/dict.py doesn't overload
__init__).