Make import cycles more predictable by prioritizing different import forms #1736
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 8 commits
June 21, 2016 20:13
…t of (pri, id, line).
Add unit tests proving that it has a beneficial effect. The new algorithm always processes x before y, while the old one gives an error when y is processed before x: ``` x.py:4: note: In module imported here: y.py: note: In class "Sub": y.py:3: error: Cannot determine type of 'attr' ```
|
I think this is as far as I'd like to take this for now. There are a few errors in our internal repos that I have to look into. |
| # suppressed contains those reachable imports that were prevented by | ||
| # --silent-imports or simply not found. | ||
|
|
||
|
|
||
| # Priorities used for imports. (Here, top-level includes inside a class.) |
There was a problem hiding this comment.
Maybe mention what priorities are used for and why.
|
Looks good, but look at the notes above. Also it would be nice to have tests that cover all the possible priorities in some way. |
|
Looks good now! Feel free to merge once you have a green build. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Partially fixes #1530.