Skip to content

Fix ForwardRef comparison in test for Python 3.14 #18885

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Apr 8, 2025

Conversation

cdce8p
Copy link
Collaborator

@cdce8p cdce8p commented Apr 5, 2025

As a result of python/cpython#129465, ForwardRef only compare true in Python 3.14 if all attributes match.

@cdce8p cdce8p requested a review from JelleZijlstra April 5, 2025 09:34
@cdce8p cdce8p added the topic-mypyc mypyc bugs label Apr 5, 2025
Copy link
Collaborator

@JukkaL JukkaL left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the fix!

@JukkaL JukkaL merged commit 3330b42 into python:master Apr 8, 2025
12 checks passed
@cdce8p cdce8p deleted the fix-forwardref-comparison branch April 8, 2025 12:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
topic-mypyc mypyc bugs
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants