Skip to content

Allow tuples as second argument to namedtuple #2262

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 5 commits into from
Oct 17, 2016
Merged

Allow tuples as second argument to namedtuple #2262

merged 5 commits into from
Oct 17, 2016

Conversation

alexjurkiewicz
Copy link
Contributor

Thanks to @rwbarton on IRC for pointers

@gvanrossum
Copy link
Member

gvanrossum commented Oct 17, 2016 via email

@alexjurkiewicz
Copy link
Contributor Author

All good, I got there eventually!

@gvanrossum
Copy link
Member

Victory! Can you also add a test or tests to check-namedtuple.test? I'd also check that this works for typing.NamedTuple as well as for collections.namedtuple.

@alexjurkiewicz
Copy link
Contributor Author

Added three extra tests -- do these cover what you want?

On Tue, 18 Oct 2016 at 02:10 Guido van Rossum notifications@github.com
wrote:

Victory! Can you also add a test or tests to check-namedtuple.test? I'd
also check that this works for typing.NamedTuple as well as for
collections.namedtuple.


You are receiving this because you authored the thread.
Reply to this email directly, view it on GitHub
#2262 (comment), or mute
the thread
https://github.com/notifications/unsubscribe-auth/AAXKde51ABsUXfozAcRPEUlKMktJWBmYks5q04_rgaJpZM4KYKC_
.

@gvanrossum gvanrossum merged commit 5e9cafb into python:master Oct 17, 2016
@gvanrossum
Copy link
Member

Thanks again!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants