Do not crash in "too few arguments" error with anon argument #3313
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
gvanrossum
approved these changes
May 3, 2017
Member
gvanrossum
left a comment
gvanrossum
left a comment
There was a problem hiding this comment.
It's fine as is but if you have a sec here are some style nits.
test-data/unit/check-functions.test
Outdated
| [builtins fixtures/list.pyi] | ||
|
|
||
| [case testAnonymousArgumentError] | ||
|
|
mypy/messages.py
Outdated
| else: | ||
| msg = 'Missing positional arguments' | ||
| if callee.name and diff: | ||
| if callee.name and [d for d in diff if d is not None]: |
Member
There was a problem hiding this comment.
This could just be if callee.name and any(diff): ... Or if that's too cryptic use any(d is not None for d in diff).
Collaborator
Author
There was a problem hiding this comment.
Heh. Should be all, thanks for the collaborative catch.
Collaborator
Author
|
... wow, who'd have thunk I'd get something so simple wrong so many times. |
Member
It's the release pressure. Happens to me all the time. Also, this logic is pretty subtle. And thanks for fixing this under pressure! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This should fix #3312