Remove use of join during semantic analysis #3320
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@ilevkivskyi I'm thinking about using this fix for the release, as this should be low-risk, though this introduces a hole in the system. If you have a better fix by the end of the day I may consider it instead if it seems straightforward enough. Otherwise, we can land a better fix after the release. |
ilevkivskyi
approved these changes
May 4, 2017
|
Confirmed that this fixes my crash. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
MROs may not be populated yet, so the join may crash when we have
a forward reference within a named tuple. See #3316 for additional
context. Fixes #3315.