Improve plugin-related error messages #3544
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Address feedback by @gvanrossum in #3517.
|
The travis failure seems like a flake (see #3543). |
gvanrossum
reviewed
Jun 14, 2017
| [out] | ||
| <ROOT>/test-data/unit/plugins/noentry.py:0: error: Plugin does not define entry point function "plugin" | ||
| tmp/mypy.ini:2: error: Plugin "noentry" does not define entry point function "plugin" |
There was a problem hiding this comment.
Here and below the full filename of the plugin would make sense.
mypy/build.py
Outdated
| @@ -397,6 +406,24 @@ def plugin_error(message: str) -> None: | |||
| return ChainedPlugin(options.python_version, custom_plugins + [default_plugin]) | |||
|
|
|||
|
|
|||
| def find_config_file_line_number(path: str, setting_name: str) -> int: | |||
There was a problem hiding this comment.
Bummer that the ConfigFile class doesn't keep track of this. I wonder if you could at least look for sections so you only find the desired option in the [mypy] section?
gvanrossum
approved these changes
Jun 16, 2017
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Address feedback by @gvanrossum in #3517.