Reject isinstance() with TypedDict and NewType #3654
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
These can't be used for runtime type checking at runtime.
|
The test failures are flakes (#3543). |
ilevkivskyi
approved these changes
Jul 4, 2017
| @@ -8,6 +8,7 @@ class type: | |||
|
|
|||
| class tuple: pass | |||
| class function: pass | |||
| class ellipsis: pass | |||
There was a problem hiding this comment.
Is this necessary? It looks like you don't use ellipses in the added tests.
There was a problem hiding this comment.
The stub for mypy_extensions uses ....
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
These can't be used with
isinstance()at runtime.