Skip to content

Added .travis.yml #378

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 3 commits into from
Aug 17, 2014
Merged

Added .travis.yml #378

merged 3 commits into from
Aug 17, 2014

Conversation

refi64
Copy link
Contributor

@refi64 refi64 commented Aug 14, 2014

Take 1! (I probably did at least one thing wrong, but I guess I'll find out...)


install: python setup.py install

script: bash travis.sh
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I might be missing something, but why not just use:
nosetests tests.py lib-typing/3.2/test_typing.py mypy/test

Or something like make test (where the make files test rule is the above)

@JukkaL
Copy link
Collaborator

JukkaL commented Aug 15, 2014

@kirbyfan64 Just a few quick notes: How do you report errors to the CI systen? What if a single step fails, would you still run the others? The script should live in a subdirectory, I think.

@mvcisback The tests use a custom test framework (Iong story...) and nose won't work. However, migrating to unittest + nose/pytest would make sense. See #381 and #380.

@mvcisback
Copy link
Contributor

@JukkaL nosetests should run any function that has the word test in it....the integration with unittest and such is optional

@refi64
Copy link
Contributor Author

refi64 commented Aug 15, 2014

@JukkaL Travis maintains a log of all the output of the commands. If a single step fails, the others do run, largely so you can still see the other tests, too. If you want me to use a Makefile though, I'll do so.

@JukkaL
Copy link
Collaborator

JukkaL commented Aug 16, 2014

How does Travis know if any of the steps in the shell script fails? Does it track the exit statuses of the commands somehow? Or does it look at the stdout/stderr output?

@refi64
Copy link
Contributor Author

refi64 commented Aug 16, 2014

@JukkaL I just fixed that.

@JukkaL
Copy link
Collaborator

JukkaL commented Aug 17, 2014

@mvcisback The mypy unit test framework uses some conventions that are incompatible with nose.

JukkaL added a commit that referenced this pull request Aug 17, 2014
@JukkaL JukkaL merged commit ba9a7ba into python:master Aug 17, 2014
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants