Skip to content

Fix overloading on Type[...] #4037

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Oct 2, 2017
Merged

Fix overloading on Type[...] #4037

merged 1 commit into from
Oct 2, 2017

Conversation

ilevkivskyi
Copy link
Member

Fixes #4027

Currently overloads on Type[...] don't accept class objects whose __init__ is itself overloaded. I fix this by simply allowing FunctionLike with .is_type_obj() returning True instead of only Callable.

@ilevkivskyi ilevkivskyi mentioned this pull request Sep 30, 2017
Closed
@gvanrossum gvanrossum merged commit 1aabd22 into python:master Oct 2, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Spurious "No overload variant matches argument types"
2 participants
@ilevkivskyi @gvanrossum