Skip to content

Specify the config file when doing a self check (!) #5279

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Jun 25, 2018
Merged

Specify the config file when doing a self check (!) #5279

Show file tree
Hide file tree
Changes from 1 commit
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
58bcf54
Specify the config file when doing a self check (!)
msullivan Jun 25, 2018
719f643
Fix the problem properly, don't remove warn_unused
msullivan Jun 25, 2018
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion mypy/test/helpers.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -39,7 +39,7 @@ def run_mypy(args: List[str]) -> None:
pytest.fail(msg="Sample check failed", pytrace=False)


def use_builtins_fixtures(options):
def use_builtins_fixtures(options: Options) -> None:
root_dir = dirname(dirname(dirname(__file__)))
options.path_prefix = os.path.join(root_dir, 'test-data', 'unit', 'lib-stub')

Expand Down
4 changes: 2 additions & 2 deletions mypy/test/testselfcheck.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -5,7 +5,7 @@

class SelfCheckSuite(Suite):
def test_mypy_package(self) -> None:
run_mypy(['-p', 'mypy'])
run_mypy(['--config-file', 'mypy_self_check.ini', '-p', 'mypy'])

def test_testrunner(self) -> None:
run_mypy(['runtests.py', 'waiter.py'])
run_mypy(['--config-file', 'mypy_self_check.ini', 'runtests.py', 'waiter.py'])
1 change: 0 additions & 1 deletion mypy_self_check.ini
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -7,7 +7,6 @@ no_implicit_optional = True
disallow_any_generics = True
disallow_any_unimported = True
warn_redundant_casts = True
warn_unused_configs = True

# needs py2 compatibility
[mypy-mypy.test.testextensions]
Expand Down