Enable --no-silence-site-packages in eval tests #5370
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
An unintended side-effect of silencing errors in site packages and typeshed by default is that our tests no longer flag changes to mypy that end up breaking typeshed in some way. (For example, see https://github.com/python/mypy/pulls/5280 which *really* should not be passing, at least as of time of writing.) This pull request will add the `--no-silence-site-packages` flag to any tests suites that directly or indirectly test typeshed. Specifically, I believe this ought to add the flag to any tests triggered by testsamples.py, testselfcheck.py, and testpythoneval.py.
emmatyping
approved these changes
Jul 17, 2018
JelleZijlstra
approved these changes
Jul 17, 2018
|
Looks like this is exposing an actual typeshed problem already: |
JelleZijlstra
added a commit
to python/typeshed
that referenced
this pull request
Jul 17, 2018
... at least according to https://docs.python.org/3/library/os.html#os.get_terminal_size. Related to python/mypy#5370.
JelleZijlstra
added a commit
to python/typeshed
that referenced
this pull request
Jul 18, 2018
... at least according to https://docs.python.org/3/library/os.html#os.get_terminal_size. Related to python/mypy#5370.
Michael0x2a
added a commit
to Michael0x2a/mypy
that referenced
this pull request
Jul 18, 2018
This is mostly so we can get python/typeshed#2338, which unblocks python#5370.
Merged
Michael0x2a
added a commit
that referenced
this pull request
Jul 18, 2018
This is mostly so we can get python/typeshed#2338, which unblocks #5370.
Michael0x2a
deleted the
always-enable-no-silence-site-packages-in-eval-tests
branch
Michael0x2a
added a commit
to Michael0x2a/mypy
that referenced
this pull request
Jul 20, 2018
This is mostly so we can get python/typeshed#2338, which unblocks python#5370.
Michael0x2a
added a commit
to Michael0x2a/mypy
that referenced
this pull request
Jul 20, 2018
An unintended side-effect of silencing errors in site packages and typeshed by default is that our tests no longer flag changes to mypy that end up breaking typeshed in some way. (For example, see https://github.com/python/mypy/pulls/5280 which *really* should not be passing, at least as of time of writing.) This pull request will add the `--no-silence-site-packages` flag to any test suites that directly or indirectly test typeshed. Specifically, I believe this PR ought to add the flag to any tests triggered by `testsamples.py`, `testselfcheck.py`, and `testpythoneval.py`.
yedpodtrzitko
pushed a commit
to yedpodtrzitko/typeshed
that referenced
this pull request
Jan 23, 2019
... at least according to https://docs.python.org/3/library/os.html#os.get_terminal_size. Related to python/mypy#5370.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
An unintended side-effect of silencing errors in site packages and typeshed by default is that our tests no longer flag changes to mypy that end up breaking typeshed in some way.
(For example, see https://github.com/python/mypy/pulls/5280 which really should not be passing, at least as of time of writing.)
This pull request will add the
--no-silence-site-packagesflag to any tests suites that directly or indirectly test typeshed.Specifically, I believe this ought to add the flag to any tests triggered by testsamples.py, testselfcheck.py, and testpythoneval.py.