Invalidate the cache if disallow_incomplete_defs changes

[asottile]

Resolves #5413

[asottile]

@gvanrossum took your advice from #5413 (comment)

I also sorted the list, I can rebase that out if it's undesirable :)

[gvanrossum]

I'm okay with sorting, though I would recommend adding a comment to the top `# Please keep this list sorted.` Also can you add a test case that reproduces the bug from #5413 to show that it's now fixed? I'd also like to see a test case showing that this flag is per-module.

[asottile]

I'm not super familiar with the test suite but I'll try and take a look at that later. I've added the comment as suggested. I also don't really know what it means to be "per-module" so I'm not sure how to test that part -- open to suggestions though :)

[gvanrossum]

A per-module flag can vary per module, see http://mypy.readthedocs.io/en/latest/config_file.html#per-module-flags

[gvanrossum]

Thanks -- let me know if you are going to add tests. Also, please don't amend or squash commits -- we'll squash them when we land, but during the review process it's easier if you create and push new local commits.

[asottile]

ah yeah, still trying to figure out the tests. I'm not really finding any other integration tests for the caching stuff or I'm not looking in the right spot. does the test framework used in ./test-data support multiple invocations of mypy? (didn't find any examples at a glance but to be honest I wasn't looking all that exhaustively)

[gvanrossum]

There are some tests in test-data/unit/check-flags.test that vary the flags in mypy.ini.

…

On Wed, Aug 1, 2018 at 7:27 PM, Anthony Sottile ***@***.***> wrote: ah yeah, still trying to figure out the tests. I'm not really finding any other integration tests for the caching stuff or I'm not looking in the right spot. does the test framework used in ./test-data support multiple invocations of mypy? (didn't find any examples at a glance but to be honest I wasn't looking all that exhaustively) — You are receiving this because you were mentioned. Reply to this email directly, view it on GitHub <#5414 (comment)>, or mute the thread <https://github.com/notifications/unsubscribe-auth/ACwrMprMqnTtetip76UQ53sBHuHeCMUDks5uMmOFgaJpZM4VrEz-> .

-- --Guido van Rossum (python.org/~guido)

[gvanrossum]

Thanks!