Skip to content

Correct lint errors and silence W504 #5830

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Oct 24, 2018
Merged

Conversation

emmatyping
Copy link
Member

Flake8 3.6.0 is a bit more strict on some things, so this fixes the complaints and silences W504 (line break after operator) since that is very common in our code (and we seem to silence W503 too).

For an example of what the failing flake8 output looks like, see https://travis-ci.org/python/mypy/jobs/445480219.

Copy link
Collaborator

@JukkaL JukkaL left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for cleaning up the lint errors! I particularly like that we can now catch missing spaces around = in argument default values.

@JukkaL JukkaL merged commit e09e727 into python:master Oct 24, 2018
@emmatyping emmatyping deleted the flake8fix branch January 31, 2019 02:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants