Fix 7412: Exception while typechecking: KeyError: 'typing' #7459
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ilevkivskyi
reviewed
Sep 4, 2019
mypy/build.py
Outdated
| @@ -2303,6 +2303,7 @@ def find_module_and_diagnose(manager: BuildManager, | |||
| if (root_source # Honor top-level modules | |||
| or (not path.endswith('.py') # Stubs are always normal | |||
| and not options.follow_imports_for_stubs) # except when they aren't | |||
| or id == 'typing' # typing is not a stub, and is always normal | |||
There was a problem hiding this comment.
I think this makes sense, to make it more general maybe use id not in mypy.semanal_main.core_modules instead of this line and the below one?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
fix for #7412 looks pretty simple... not sure if this solution is general enough