-
-
Notifications
You must be signed in to change notification settings - Fork 3k
Fix issubclass()
to narrow down types of type variables
#7930
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
Changes from 2 commits
Commits
Show all changes
8 commits
Select commit
Hold shift + click to select a range
796f527
add testcase
TH3CHARLie 238bfa8
modify find_isinstance_check in checker.py to fix bug
TH3CHARLie 5b35e9d
adjust branch statement in checker.py, modify testcase
TH3CHARLie df62cbc
refactor issubclass check into helper function
TH3CHARLie 316cca7
modify test by adding new class with different upper bound, add docst…
TH3CHARLie e987e42
modify testcase, modify helper function name
TH3CHARLie 8ab0d96
Remove redundant parens
ilevkivskyi fe59c0d
Merge branch 'master' into fix-issubclass
ilevkivskyi File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
|
@@ -6512,3 +6512,28 @@ def access_after_declaration(self) -> None: | |
|
||
reveal_type(x) # N: Revealed type is 'builtins.int' | ||
x = x + 1 | ||
|
||
[case testIsSubClassNarrowDownTypesOfTypeVariables] | ||
from typing import TypeVar, Generic | ||
|
||
TypeT = TypeVar("TypeT", bound=type) | ||
|
||
class IntBase: | ||
field: int = 42 | ||
|
||
class IntFoo(Generic[TypeT]): | ||
def method(self, other: TypeT) -> int: | ||
if issubclass(other, IntBase): | ||
return other.field | ||
ilevkivskyi marked this conversation as resolved.
Show resolved
Hide resolved
|
||
return 0 | ||
|
||
class StrBase: | ||
field: str = "hello" | ||
|
||
class StrFoo(Generic[TypeT]): | ||
def method(self, other: TypeT) -> str: | ||
if issubclass(other, StrBase): | ||
return other.field | ||
return "hi" | ||
TH3CHARLie marked this conversation as resolved.
Show resolved
Hide resolved
|
||
|
||
[builtins fixtures/isinstancelist.pyi] | ||
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. OK, now the two classes don't look the same, but you didn't do what I asked, I wanted type variables with different upper bounds, like |
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading. Please reload this page.