Skip to content

Add narrowing Union w/ bool Literal via identity check #8821

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 3 commits into from
May 19, 2020
Merged

Add narrowing Union w/ bool Literal via identity check #8821

merged 3 commits into from
May 19, 2020

Conversation

sbdchd
Copy link
Contributor

@sbdchd sbdchd commented May 14, 2020

Allows for narrowing Union[str, Literal[False]] via is not False.

related: #8368

fixes: #8810

@sbdchd
Add narrowing Union with boolean Literal with identity check
56da848 
Allows for narrowing `Union[str, Literal[False]]` via `is not False`.

related: #8368

fixes: #8810
@sbdchd sbdchd changed the title Add narrowing Union with boolean Literal with identity check Add narrowing Union w/ bool Literal via identity check May 14, 2020
msullivan
msullivan approved these changes May 19, 2020
View reviewed changes
Copy link
Collaborator

@msullivan msullivan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good catch. Thanks!

@msullivan msullivan merged commit 65e3a89 into python:master May 19, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@msullivan msullivan msullivan approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Narrow Union[str, Literal[False]] via is
2 participants
@sbdchd @msullivan