Skip to content

include mypyc subdirectories in the sdist #8949

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Jun 6, 2020

Conversation

mr-c
Copy link
Contributor

@mr-c mr-c commented Jun 4, 2020

Needed for the Debian package of mypy as we use mypyc during building.

@mr-c mr-c force-pushed the manifest_mypyc_ir branch from 9f24127 to e9d26d4 Compare June 4, 2020 12:12
@mr-c mr-c changed the title include mypyc/ir/*.py in the sdist include mypyc subdirectories in the sdist Jun 4, 2020
@mr-c
Copy link
Contributor Author

mr-c commented Jun 4, 2020

Originally I was going to patch in the missing files, when I thought it was just one directory. Now it is a lot of directories, so with my Debian hat on I would like to request a 0.781 release with this fix.

Thanks, as always, for such a great project!

@mr-c
Copy link
Contributor Author

mr-c commented Jun 4, 2020

I can contribute a test for this error, if that would be welcome.

@msullivan
Copy link
Collaborator

A test with that error would be fantastic, because we mess this up a lot >_>

@ilevkivskyi what do you think about a point release?

@msullivan msullivan merged commit 8cc06b7 into python:master Jun 6, 2020
@ilevkivskyi
Copy link
Member

Yes, I will release 0.781 tomorrow. What exactly should I cherry-pick? Just this PR?

@mr-c mr-c deleted the manifest_mypyc_ir branch June 7, 2020 21:51
@mr-c mr-c mentioned this pull request Jun 7, 2020
@mr-c
Copy link
Contributor Author

mr-c commented Jun 12, 2020

FYI, one cannot pip install mypy in Python 3.9 and have mypyc working as there is no binary wheel for mypy 0.780 for Python 3.9 yet

@msullivan
Copy link
Collaborator

FYI, one cannot pip install mypy in Python 3.9 and have mypyc working as there is no binary wheel for mypy 0.780 for Python 3.9 yet

There's still a none wheel, though, right?

@mr-c
Copy link
Contributor Author

mr-c commented Jun 12, 2020

There's still a none wheel, though, right?

The none wheel for 0.780 is missing the same sub-directories under mypyc/ as the sdist is 🥺

@mr-c
Copy link
Contributor Author

mr-c commented Jun 18, 2020

@ilevkivskyi 0.781 should also include 4d9a07d

@ilevkivskyi
Copy link
Member

I already released 0.781 without this one. We are however thinking about 0.782 (for couple other fixes), so we will include it there.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants